Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds licence expiry details #54081

Merged
merged 9 commits into from
Jan 9, 2020
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 7, 2020

Summary

This PR adds licence expiration information to the Kibana Guide. It was previously located in the Stack Overview (https://www.elastic.co/guide/en/elastic-stack-overview/master/license-expiration.html).

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

[skip ci]

Preview:
http://kibana_54081.docs-preview.app.elstc.co/guide/en/kibana/master/managing-licenses.html

@lcawl lcawl added Team:Docs WIP Work in progress v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl removed the WIP Work in progress label Jan 8, 2020
@lcawl lcawl marked this pull request as ready for review January 8, 2020 19:37
@lcawl lcawl requested review from gchaps and debadair January 8, 2020 19:58
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about combining these two topics into a single topic?


* APIs to create {anomaly-jobs}, open jobs, send data to jobs, create {dfeeds},
and start {dfeeds} are disabled.
* All started {dfeeds} are stopped. All open {anomaly-jobs} are closed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be two separate bullet points?

docs/management/license-expiration.asciidoc Outdated Show resolved Hide resolved
==== {kib}

* Users can still log into {kib}.
* It is still usable for data exploration and visualization, but some features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana works for data exploration and visualization, but some features are disabled.

@lcawl
Copy link
Contributor Author

lcawl commented Jan 8, 2020

What about combining these two topics into a single topic?

I'm generally not a fan of overly long pages, but if that's your preference here, I'll draft that change.

@gchaps
Copy link
Contributor

gchaps commented Jan 8, 2020

As I don't feel strongly about this, we can leave as two pages.

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit daffda7 into elastic:master Jan 9, 2020
@lcawl lcawl deleted the licence-expiry branch January 9, 2020 17:28
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 9, 2020
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 9, 2020
@lcawl lcawl added the 7.5.2 label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.5.2 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants